Discussion:
[OpenOCD-devel] [PATCH]: f35bdbb telnet_server: increase buffer sizes to allow longer commands.
gerrit
2017-05-10 15:51:24 UTC
Permalink
This is an automated email from Gerrit.

Karl Palsson (***@tweak.net.au) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/4132

-- gerrit

commit f35bdbb3c01812fe3e7ad55f41c4311c861b3c14
Author: Karl Palsson <***@tweak.net.au>
Date: Wed May 10 14:37:51 2017 +0000

telnet_server: increase buffer sizes to allow longer commands.

A common use case seen in the wild is echoing a string of commands to an
existing openocd instance via netcat. The sequence of ; separated
commands can easily run over the line limit of only 256 chars.

Increasing this dramatically reduces surprises, at the expense of a tiny
amount of extra ram usage.

Change-Id: I2389d99d316a96b5fa03f0894b43c412308e12c4
Signed-off-by: Karl Palsson <***@tweak.net.au>

diff --git a/src/server/telnet_server.h b/src/server/telnet_server.h
index e43d6bc..f8fb826 100644
--- a/src/server/telnet_server.h
+++ b/src/server/telnet_server.h
@@ -27,10 +27,10 @@

#include <server/server.h>

-#define TELNET_BUFFER_SIZE (1024)
+#define TELNET_BUFFER_SIZE (10*1024)

#define TELNET_LINE_HISTORY_SIZE (128)
-#define TELNET_LINE_MAX_SIZE (256)
+#define TELNET_LINE_MAX_SIZE (10*256)

enum telnet_states {
TELNET_STATE_DATA,

--

Loading...