[OpenOCD-devel] [PATCH]: f2d8ea1 rtos: better sanity checking for uCOS-III

[gerrit]

This is an automated email from Gerrit.

Steven Stallion (***@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/4166

-- gerrit

commit f2d8ea1ea918c97803854c6d28403f5e1382c863
Author: Steven Stallion <***@squareup.com>
Date: Wed Jun 21 22:14:08 2017 -0700

rtos: better sanity checking for uCOS-III

This patch improves the OSRunning check. If the rtos_running check
fails, update_threads will return an error rather than attempt to update
the thread list using bad values.

Change-Id: I8614c325504d3a9ab19aebb6862b1fe445a0c8e7
Signed-off-by: Steven Stallion <***@squareup.com>

diff --git a/src/rtos/uCOS-III.c b/src/rtos/uCOS-III.c
index 9021167..0a0fb3e 100644
--- a/src/rtos/uCOS-III.c
+++ b/src/rtos/uCOS-III.c
@@ -300,6 +300,11 @@ static int uCOS_III_update_threads(struct rtos *rtos)
return retval;
}

+ if (rtos_running != 1 && rtos_running != 0) {
+ LOG_ERROR("uCOS-III: invalid RTOS running value");
+ return ERROR_FAIL;
+ }
+
if (!rtos_running) {
rtos->thread_details = calloc(1, sizeof(struct thread_detail));
if (rtos->thread_details == NULL) {

--