[OpenOCD-devel] [PATCH]: d5c2b41 server: gdb: always print target information in multi-target setups

[gerrit]

This is an automated email from Gerrit.

Paul Fertser (***@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/4135

-- gerrit

commit d5c2b41331e14fa9ca97ee0e135484cce50b3582
Author: Paul Fertser <***@gmail.com>
Date: Wed May 17 11:03:19 2017 +0300

server: gdb: always print target information in multi-target setups

When multiple targets are declared, it's not always obvious which
target the connection was made for, this can lead to very confusing
errors.

Reported by zjason on IRC.

Change-Id: I52906320394e89cb6cfe82054a3f94b27c999689
Signed-off-by: Paul Fertser <***@gmail.com>

diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c
index 483e551..d027b54 100644
--- a/src/server/gdb_server.c
+++ b/src/server/gdb_server.c
@@ -990,7 +990,9 @@ static int gdb_new_connection(struct connection *connection)
}

gdb_actual_connections++;
- LOG_DEBUG("New GDB Connection: %d, Target %s, state: %s",
+ log_printf_lf(all_targets->next != NULL ? LOG_LVL_INFO : LOG_LVL_DEBUG,
+ __FILE__, __LINE__, __func__,
+ "New GDB Connection: %d, Target %s, state: %s",
gdb_actual_connections,
target_name(gdb_service->target),
target_state_name(gdb_service->target));

--