Discussion:
[OpenOCD-devel] [PATCH]: ab7fa91 server: Add port number to socket bind error
gerrit
2017-06-07 21:00:25 UTC
Permalink
This is an automated email from Gerrit.

Robert Foss (***@memcpy.io) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/4157

-- gerrit

commit ab7fa91f7054d8c919deb126a4b623f79b8265d9
Author: Robert Foss <***@collabora.com>
Date: Wed Jun 7 16:49:29 2017 -0400

server: Add port number to socket bind error

Make this error message more useful by providing the port number
that we tried to bind to.

Change-Id: Ieb18adf0725a6ae99c77ebfaadc49d64ed407bbe
Signed-off-by: Robert Foss <***@collabora.com>

diff --git a/src/server/server.c b/src/server/server.c
index 8009d40..517d62a 100644
--- a/src/server/server.c
+++ b/src/server/server.c
@@ -273,7 +273,7 @@ int add_service(char *name,
c->sin.sin_port = htons(c->portnumber);

if (bind(c->fd, (struct sockaddr *)&c->sin, sizeof(c->sin)) == -1) {
- LOG_ERROR("couldn't bind %s to socket: %s", name, strerror(errno));
+ LOG_ERROR("couldn't bind %s to socket on port %d: %s", name, c->portnumber, strerror(errno));
close_socket(c->fd);
free_service(c);
return ERROR_FAIL;

--

Loading...