[OpenOCD-devel] Adding new SiLabs EFM32/EFR32 chips

[Jonas Norling]

Hello list,

There are a bunch of commits that add support for various Silicon Labs
EFM32 and EFR32 devices, that have been sitting around in Gerrit for a
long time now. Those are pretty nice chips, so it would be a shame if we
didn't get some of that work reviewed and merged ;-)

Those patches are in various state of review, but haven't been touched
for months:

http://openocd.zylin.com/#/c/4034

http://openocd.zylin.com/#/c/3736

http://openocd.zylin.com/#/c/3911

http://openocd.zylin.com/#/c/3850

http://openocd.zylin.com/#/c/3934


In case none of those should please the maintainers, I have published my
own take at supporting those chips:

http://openocd.zylin.com/#/c/4169

http://openocd.zylin.com/#/c/4170

http://openocd.zylin.com/#/c/4171

The code has been tested with EFR32FG12P and EFR32MG2P.


So it would be nice if someone could review, and eventually merge, those
patches.

Thanks,

Jonas Norling



[Cyan Connode Logo]<http://www.cyanconnode.com> [Cyan Connode Logo]

Jonas Norling



[phone]

www.cyanconnode.com<http://www.cyanconnode.com>

This e-mail message is confidential and for use by the addressee only. If you are not the intended recipient, please contact us, delete the message from your computer and destroy any copies.

Accordingly any dissemination, distribution, copying or other use of this message or any of its content by any person other than the intended recipient is strictly prohibited. Internet e-mails are not necessarily secure, therefore responsibility is not accepted for changes made to this message after it was sent.

Any views or opinions expressed are solely those of the author and do not necessarily represent those of CyanConnode Holdings plc or any associated or subsidiary companies. This email has been scanned for viruses. It is the responsibility of the recipient to ensure that the onward transmission, opening or use of this message and any attachments will not adversely affect its systems or data.

CyanConnode Holdings plc, Merlin Place, Milton Road, Cambridge CB4 0DP

[Freddie Chopin]

Post by Jonas Norling
So it would be nice if someone could review, and eventually merge, those
patches.

It is worth noting that you can also review these changes, but by
adding yet another set of patches the situation just gets harder... I
suggest you either abandon your changes or suggest abandoning all the
changes that your patches supersede.

Regards,
FCh

[Jonas Norling]

Hi,

Thanks for your input. I have done my best to review the relevant
patches now. Merging http://openocd.zylin.com/#/c/3934 should be a
no-brainer, IMHO.

I'll withdraw my patches and possibly re-submit EFR32FG support once
some of the earlier patches get merged.

BR,
Jonas Norling

Post by Freddie Chopin

Post by Jonas Norling
So it would be nice if someone could review, and eventually merge, those
patches.

It is worth noting that you can also review these changes, but by
adding yet another set of patches the situation just gets harder... I
suggest you either abandon your changes or suggest abandoning all the
changes that your patches supersede.
Regards,
FCh

[Cyan Connode Logo]<http://www.cyanconnode.com> [Cyan Connode Logo]

Jonas Norling



[phone]

www.cyanconnode.com<http://www.cyanconnode.com>

This e-mail message is confidential and for use by the addressee only. If you are not the intended recipient, please contact us, delete the message from your computer and destroy any copies.

Accordingly any dissemination, distribution, copying or other use of this message or any of its content by any person other than the intended recipient is strictly prohibited. Internet e-mails are not necessarily secure, therefore responsibility is not accepted for changes made to this message after it was sent.

Any views or opinions expressed are solely those of the author and do not necessarily represent those of CyanConnode Holdings plc or any associated or subsidiary companies. This email has been scanned for viruses. It is the responsibility of the recipient to ensure that the onward transmission, opening or use of this message and any attachments will not adversely affect its systems or data.

CyanConnode Holdings plc, Merlin Place, Milton Road, Cambridge CB4 0DP

[Freddie Chopin]

Post by Jonas Norling
Merging http://openocd.zylin.com/#/c/3934 should be a
no-brainer, IMHO.

Done.

Post by Jonas Norling
I'll withdraw my patches and possibly re-submit EFR32FG support once
some of the earlier patches get merged.

You can also pull patches from gerrit and improve them yourself. This
may be a good idea if the original author seems to be gone or no longer
interested in fixing issues pointed in the review.

Regards,
FCh